[Wizard] Show notification instead of finished page when pairing succeeds
ClosedPublic
Actions

Authored by broulik on Dec 20 2019, 11:09 AM.

Details

Reviewers

Group Reviewers

VDG
Plasma

Commits

Summary

Saves the user from having to close the dialog when pairing succeeded.

Test Plan

Depends on D25935 for that special hint

Not too happy about this approach, but done is protected, just closing the dialog from the page doesn't properly dismiss it. Maybe I should add a signal on the page instead?

Repository

R97 Bluedevil

Lint

Lint Skipped

Unit

Unit Tests Skipped

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

broulik requested review of this revision.Dec 20 2019, 11:09 AM

broulik edited the test plan for this revision. (Show Details)

Yep, much nicer.

This revision is now accepted and ready to land.Jan 13 2020, 12:02 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			src/bluedevil.notifyrc (6 lines)
M			src/wizard/CMakeLists.txt (1 line)
M			src/wizard/bluewizard.cpp (8 lines)
M			src/wizard/pages/success.cpp (30 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	71879			Dec 20 2019, 11:07 AM	★	★
Diff 2	71887			Dec 20 2019, 12:51 PM	★	★
Diff 3	73396	9291b9d	R97:5101d7902f9f08a42862575304de8bf6d8b0aa07	Jan 13 2020, 12:07 PM	★	★

	Status	Author	Revision
	Closed	broulik	D26120 [Wizard] Show notification instead of finished page when pairing succeeds
	Closed	broulik	D25935 [Notifications] Add hint for a notification being response to explicit user interaction