Differential D26115

Fixed broken SVN Commit dialog.
ClosedPublic
Actions

Authored by nikolaik on Dec 20 2019, 7:21 AM.

Details

Reviewers
elvisangelaccio
meven
ngraham
Group Reviewers
Dolphin
Commits
R449:e8f6c72a3779: Fixed broken SVN Commit dialog.
Summary

SVN commit dialog was showing incorrectly because QDialogBox buttons were not attached to the dialog window.
Also fixing memory leak on QDialogButtonBox creating.

Diff Detail

Repository
R449 Plugins for Dolphin
Branch
svn_commit
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 20067
Build 20085: arc lint + arc unit
nikolaik requested review of this revision.Dec 20 2019, 7:21 AM
nikolaik created this revision.
meven accepted this revision.Dec 21 2019, 12:54 PM
meven added a reviewer: elvisangelaccio.
meven added a subscriber: meven.

Seems fine to me

This revision is now accepted and ready to land.Dec 21 2019, 12:55 PM
elvisangelaccio accepted this revision.Dec 21 2019, 6:21 PM
Closed by commit R449:e8f6c72a3779: Fixed broken SVN Commit dialog. (authored by nikolaik, committed by ngraham). · Explain WhyDec 21 2019, 7:38 PM
This revision was automatically updated to reflect the committed changes.
ngraham added a comment.Dec 21 2019, 7:40 PM

Thanks very much for the contribution. May it be the first of many!

Revision Contents
Changeset List

PathPackages
Msvn/fileviewsvnplugin.cpp (10 lines)

Diff 71863

View Options

svn/fileviewsvnplugin.cpp

Loading...