[XembedSNIProxy] Regression - really resize instead of notifying only.

Authored by kmaterka on Dec 18 2019, 4:08 PM.



Regression introduced in previous commit, review D26079. Tray icons should have an ability to resize. If not, icons smaller than 32x32 will render incorectly. In addition, do not notify using xcb_configure_notify_event_t, in some cases (Wine) it messes up the event handling.

BUG: 414667
FIXED-IN: 5.18.0

Test Plan

Tested with keepass2, keepassx, pidgin, xchat, hexchat, tuxguitar, liferea, wine tflash.exe, workrave, stardict

Diff Detail

R120 Plasma Workspace
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
kmaterka requested review of this revision.Dec 18 2019, 4:08 PM
kmaterka created this revision.
kmaterka added a comment.EditedDec 18 2019, 4:10 PM

I don't know why I missed that, I tested D26079 but obviously not enough.

kmaterka added inline comments.Dec 18 2019, 4:14 PM


@davidedmundson In this commit you added xcb_configure_notify_event_t to resize window. Do you remember why and which application were not working correctly? Seems that old review board os down.


xcb_flush is probably not needed, but better make sure is is handled before we capture image.

davidedmundson accepted this revision.Dec 19 2019, 10:51 AM
davidedmundson added inline comments.

No idea. It was before a lot of other refractors.

Things could well have changed since.

Let's go with this and monitor feedback.

This revision is now accepted and ready to land.Dec 19 2019, 10:51 AM
This revision was automatically updated to reflect the committed changes.
kmaterka edited the summary of this revision. (Show Details)Dec 19 2019, 12:46 PM