Differential D26086

Don't fetch pixmap if we have it already
ClosedPublic
Actions

Authored by broulik on Dec 18 2019, 3:15 PM.

Details

Reviewers
hein
Group Reviewers
Plasma
Commits
R120:08f02266c922: Don't fetch pixmap if we have it already
Summary

AppData contains a QIcon with pixmap data gathered from KWindowSystem::icon which we can just use.
Only if, for some reason, the icon is really null, try getting it from KWindowSystem on demand.

Test Plan

Pinned my xcalc to the task bar, got the same pixmap serialized as before, without a roundtrip to the x server

Diff Detail

Repository
R120 Plasma Workspace
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.Dec 18 2019, 3:15 PM
Restricted Application added a project: Plasma. · View Herald TranscriptDec 18 2019, 3:15 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Dec 18 2019, 3:15 PM
hein accepted this revision.Jan 4 2020, 11:06 PM
This revision is now accepted and ready to land.Jan 4 2020, 11:06 PM
Closed by commit R120:08f02266c922: Don't fetch pixmap if we have it already (authored by broulik). · Explain WhyJan 5 2020, 11:09 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mlibtaskmanager/xwindowtasksmodel.cpp (11 lines)

Diff 71794

View Options

libtaskmanager/xwindowtasksmodel.cpp

Loading...