Differential D26077

[kcms/ksmserver] Swap shutdown options
ClosedPublic
Actions

Authored by broulik on Dec 18 2019, 9:00 AM.

Details

Reviewers
ervin
romangg
Group Reviewers
Plasma
Commits
R119:c4dc4bd45238: [kcms/ksmserver] Swap shutdown options
Summary

With kcfg magic the order of the radio buttons determines the enum value. Just swap them so they're correct again.

BUG: 415308

Test Plan
  • Configured shutdown, hit power button, got shutdown pre-selected

Diff Detail

Repository
R119 Plasma Desktop
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.Dec 18 2019, 9:00 AM
Restricted Application added a project: Plasma. · View Herald TranscriptDec 18 2019, 9:00 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Dec 18 2019, 9:00 AM
romangg accepted this revision.Dec 18 2019, 9:06 AM
romangg added a subscriber: romangg.

Fastest bug-to-fix process this year?

This revision is now accepted and ready to land.Dec 18 2019, 9:06 AM
romangg resigned from this revision.Dec 18 2019, 9:15 AM

Kai said that he wants to wait on @ervin's opinion since this patch would change the button order and maybe there is a way to solve the issue without doing that.

This revision now requires review to proceed.Dec 18 2019, 9:15 AM
ervin accepted this revision.Dec 23 2019, 12:52 PM

I'm surprised, I was sure I checked that... but maybe I did it only for the loginMode. This is indeed the better quick and dirty fix we can apply for now.

This revision is now accepted and ready to land.Dec 23 2019, 12:52 PM
Closed by commit R119:c4dc4bd45238: [kcms/ksmserver] Swap shutdown options (authored by broulik). · Explain WhyJan 3 2020, 12:23 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 71761

View Options

kcms/ksmserver/smserverconfigdlg.ui

Loading...