Documentation improves
ClosedPublic

Authored by Abella on Dec 17 2019, 10:24 AM.

Details

Reviewers
mreeves
yurchor
Group Reviewers
Documentation
Summary

I edited it following the KDE Documentation style, make it more understandable

Diff Detail

Repository
R983 KDiff3
Branch
Documentation_improves (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 20008
Build 20026: arc lint + arc unit
Abella created this revision.Dec 17 2019, 10:24 AM
Restricted Application added a project: Documentation. · View Herald TranscriptDec 17 2019, 10:24 AM
Restricted Application added a subscriber: kde-doc-english. · View Herald Transcript
Abella requested review of this revision.Dec 17 2019, 10:24 AM

Please, I whait your impressions.

yurchor accepted this revision as: yurchor.Dec 17 2019, 3:37 PM
This revision is now accepted and ready to land.Dec 17 2019, 3:37 PM
Abella requested review of this revision.Dec 17 2019, 5:35 PM
mreeves accepted this revision.Dec 17 2019, 11:57 PM

I will be able to conduct a proper review on Friday. From a quick glance through I seems ok from my end.

This revision is now accepted and ready to land.Dec 17 2019, 11:57 PM
Abella updated this revision to Diff 71774.Dec 18 2019, 10:42 AM
  • Merge branch 'master' into Documentation_improves

arc land failled?

Total 5 (delta 3), reused 0 (delta 0)
remote: FATAL: W refs/heads/master kdiff3 bellaperez DENIED by refs/.*
remote: error: hook declined to update refs/heads/master
To git.kde.org:kdiff3
 ! [remote rejected] d7fe42c35dbf852c7bb5ef857f24834b5dd57bbf -> master (hook declined)
error: s'ha produït un error en pujar algunes referències a «git@git.kde.org:kdiff3»
Usage Exception: Push failed! Fix the error and run "arc land" again.

arc land failled?

Total 5 (delta 3), reused 0 (delta 0)
 remote: FATAL: W refs/heads/master kdiff3 bellaperez DENIED by refs/.*
 remote: error: hook declined to update refs/heads/master
 To git.kde.org:kdiff3
  ! [remote rejected] d7fe42c35dbf852c7bb5ef857f24834b5dd57bbf -> master (hook declined)
 error: s'ha produït un error en pujar algunes referències a «git@git.kde.org:kdiff3»
 Usage Exception: Push failed! Fix the error and run "arc land" again.

'arc land' does not work for invent.kde.org. You should use

git format-patch -1

to create the patch from your branch, then clone the repo from invent:

git clone git@invent.kde.org:kde/kdiff3.git

then

git am <your_patch>

then

git push