Differential D26057

Deprecate the top-level IconSize() function
ClosedPublic
Actions

Authored by vkrause on Dec 16 2019, 7:08 PM.

Details

Reviewers
apol
Maniphest Tasks
T11637: KIconThemes Cleanups
Commits
R302:3e668c7fba9f: Deprecate the top-level IconSize() function
Summary

This removes the last of the non-namespaced top-level functions here
as well.

Diff Detail

Repository
R302 KIconThemes
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
vkrause created this revision.Dec 16 2019, 7:08 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptDec 16 2019, 7:08 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
vkrause requested review of this revision.Dec 16 2019, 7:08 PM
apol accepted this revision.Dec 17 2019, 11:54 AM
This revision is now accepted and ready to land.Dec 17 2019, 11:54 AM
Closed by commit R302:3e668c7fba9f: Deprecate the top-level IconSize() function (authored by vkrause). · Explain WhyDec 17 2019, 5:16 PM
This revision was automatically updated to reflect the committed changes.
dfaure added a subscriber: dfaure.Jan 11 2020, 8:02 PM

Please port kdeclarative.

kdeclarative/private/kiconprovider.cpp:44:56: error: ‘IconSize’ was not declared in this scope

pixmap = QIcon::fromTheme(source.at(0)).pixmap(IconSize(KIconLoader::Desktop));

Detected by http://www.davidfaure.fr/2020/542.diff (to be applied to kdeclarative)

Thanks.

vkrause added a comment.Jan 12 2020, 10:59 AM
In D26057#592147, @dfaure wrote:

Please port kdeclarative.

kdeclarative/private/kiconprovider.cpp:44:56: error: ‘IconSize’ was not declared in this scope

pixmap = QIcon::fromTheme(source.at(0)).pixmap(IconSize(KIconLoader::Desktop));

Detected by http://www.davidfaure.fr/2020/542.diff (to be applied to kdeclarative)

Thanks.

Done in D26603.

Revision Contents
Changeset List

PathPackages
Msrc/CMakeLists.txt (2 lines)
Msrc/kiconloader.h (5 lines)
Msrc/kiconloader.cpp (2 lines)

Diff 71737

View Options

src/CMakeLists.txt

Loading...
View Options

src/kiconloader.h

Loading...
View Options

src/kiconloader.cpp

Loading...