[dataengine/geolocation] Add logging category
ClosedPublic

Authored by meven on Dec 16 2019, 4:45 PM.

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
meven created this revision.Dec 16 2019, 4:45 PM
Restricted Application added a project: Plasma. · View Herald TranscriptDec 16 2019, 4:45 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
meven requested review of this revision.Dec 16 2019, 4:45 PM

if we're going to fix qDebug, lets fix the qDebug and move to categorized logging

// qDebug() << "gpsd not found";

seems like an important warning

meven added a comment.Dec 16 2019, 8:55 PM

if we're going to fix qDebug, lets fix the qDebug and move to categorized logging

// qDebug() << "gpsd not found";

seems like an important warning

I thought we might want to add a proper logging setup here.
Did not take the time to do it properly.
Probably will.

meven retitled this revision from [dataengine/geolocalisation] clean debug traces to [dataengine/geolocalisation] Add logging category.Dec 17 2019, 7:34 AM
meven retitled this revision from [dataengine/geolocalisation] Add logging category to [dataengine/geolocation] Add logging category.
meven updated this revision to Diff 71704.Dec 17 2019, 7:36 AM

Add logging category

davidedmundson accepted this revision.Dec 17 2019, 10:16 AM
This revision is now accepted and ready to land.Dec 17 2019, 10:16 AM
meven added inline comments.Dec 17 2019, 10:26 AM
dataengines/geolocation/location_gps.cpp
98

Change to qCWarning

meven updated this revision to Diff 71710.Dec 17 2019, 11:34 AM

Use qCDebug/qCWarning instead of qDebug/qWarning

This revision was automatically updated to reflect the committed changes.