Differential D26052

KCM Cursor Theme : Use ManagedConfigModule
ClosedPublic
Actions

Authored by bport on Dec 16 2019, 4:26 PM.

Details

Reviewers
ervin
crossi
ngraham
meven
Group Reviewers
Plasma
Commits
R119:1e4271fb4cc3: KCM Cursor Theme : Use ManagedConfigModule
Summary

Use ManagedConfigModule instead of ConfigModule to remove uneeded code

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bport created this revision.Dec 16 2019, 4:26 PM
Restricted Application added a project: Plasma. · View Herald TranscriptDec 16 2019, 4:26 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
bport requested review of this revision.Dec 16 2019, 4:26 PM
meven accepted this revision.Dec 16 2019, 4:51 PM
This revision is now accepted and ready to land.Dec 16 2019, 4:51 PM
meven resigned from this revision.Dec 16 2019, 4:53 PM

Looks good to me
Someone from Plasma will be a better reviewer

This revision now requires review to proceed.Dec 16 2019, 4:53 PM
meven added a subscriber: meven.Dec 16 2019, 4:56 PM
crossi added inline comments.Dec 17 2019, 9:21 AM
kcms/cursortheme/kcmcursortheme.cpp
366–367

Now you should simply call ManagedConfigModule::save(); instead

383–384

ManagedConfigModule::load();

403

ManagedConfigModule::defaults();

bport updated this revision to Diff 71958.Dec 21 2019, 4:25 PM

Call ManagedConfiModule load/save/defaults parent method

bport marked 3 inline comments as done.Dec 21 2019, 4:25 PM
ngraham accepted this revision.Dec 21 2019, 4:58 PM
ngraham added a subscriber: ngraham.

Maybe next you can figure out what causes this bizarre behavior:

This revision is now accepted and ready to land.Dec 21 2019, 4:58 PM
ervin accepted this revision.Dec 23 2019, 12:31 PM
Closed by commit R119:1e4271fb4cc3: KCM Cursor Theme : Use ManagedConfigModule (authored by bport). · Explain WhyDec 26 2019, 8:38 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 72191

View Options

kcms/cursortheme/cursorthemesettings.kcfgc

Loading...
View Options

kcms/cursortheme/kcmcursortheme.h

Loading...
View Options

kcms/cursortheme/kcmcursortheme.cpp

Loading...