For KCM Notification, allow to register the generated settings to the ManagedConfigModule machinery
Details
- Reviewers
ervin bport davidedmundson mart meven - Group Reviewers
Plasma Frameworks - Commits
- R120:ee3176ce5641: Expose KConfig settings to allow registration in KCM Notification
refactor, no change
Diff Detail
- Repository
- R120 Plasma Workspace
- Lint
Lint Skipped - Unit
Unit Tests Skipped - Build Status
Buildable 21439 Build 21457: arc lint + arc unit
libnotificationmanager/settings.h | ||
---|---|---|
343 | Not a fan of this becoming public API |
libnotificationmanager/settings.h | ||
---|---|---|
343 | Maybe not the best approach. Any suggestion to access the KCoreConfigSkeleton encapsulated to register them in the KCM's ConfigModule ? |
libnotificationmanager/settings.h | ||
---|---|---|
343 | Will need API documentation | |
343 | @broulik I understand you don't like much this becoming exposed as one could abuse it to kill encapsulation and state... but we can't have it both ways either. This facade makes it impossible to plug as is in existing systems around KCM or ConfigModule without large efforts. I don't think we can have it both ways here. |
Other than the seemingly missing config, looks good
libnotificationmanager/settings.cpp | ||
---|---|---|
173 | I still want to be able to specify what config (constructor argument) to use for autotests |
libnotificationmanager/settings.cpp | ||
---|---|---|
173 | After discussing with kai, let's mark the ctor taking the config parameter as deprecated instead. Should be done in another patch, this one can go as is. |