Differential D26045

Add immutability to KCM Icons
ClosedPublic
Actions

Authored by bport on Dec 16 2019, 3:30 PM.

Details

Reviewers
ervin
ngraham
crossi
meven
Group Reviewers
Plasma
Commits
R119:097ad69d5e8b: Add immutability to KCM Icons
Summary

Add immutability to KCM Icons, disable theme delegate and not the whole grid in order to allow user to change icon size if not immutable too

Test Plan

Add [$i] to kdeglobals key

Diff Detail

Repository
R119 Plasma Desktop
Lint
Lint Skipped
Unit
Unit Tests Skipped
Build Status
Buildable 20127
Build 20145: arc lint + arc unit
bport created this revision.Dec 16 2019, 3:30 PM
Restricted Application added a project: Plasma. · View Herald TranscriptDec 16 2019, 3:30 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
bport requested review of this revision.Dec 16 2019, 3:30 PM
broulik added a subscriber: broulik.Dec 17 2019, 8:57 AM
broulik added inline comments.
kcms/icons/package/contents/ui/main.qml
38

Why this change?

58

Shouldn't this be set on the grid view then, i.e. the view.enabled stuff Marco fixed a while back?

231

This is the default

crossi added inline comments.Dec 17 2019, 9:29 AM
kcms/icons/package/contents/ui/main.qml
58

Yes it should.

bport added inline comments.Dec 21 2019, 11:30 AM
kcms/icons/package/contents/ui/main.qml
38

my bad, need to keep the downloaded stuff there

58

Problem with this solution it will disable also icon size components, and we don't want that, if you have a nicer solution

bport updated this revision to Diff 71957.Dec 21 2019, 4:10 PM

Take in consideration broulik feedback

bport added inline comments.Dec 21 2019, 4:10 PM
kcms/icons/package/contents/ui/main.qml
58

my bad missread indeed view.enabled do what I want

bport marked 2 inline comments as done.Dec 21 2019, 4:11 PM
ngraham added a comment.Dec 21 2019, 4:51 PM

Needs a rebase

ervin accepted this revision.EditedDec 23 2019, 11:27 AM

Looks good to me (of course assuming the rebase won't lead to large changes to that patch).

This revision is now accepted and ready to land.Dec 23 2019, 11:27 AM
Closed by commit R119:097ad69d5e8b: Add immutability to KCM Icons (authored by bport). · Explain WhyDec 31 2019, 8:28 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 71957

View Options

kcms/icons/package/contents/ui/IconSizePopup.qml

Loading...
View Options

kcms/icons/package/contents/ui/main.qml

Loading...