LLDB/GDB plugin: add support for coredumpctl in unittests, and fix LldbTest::testCoreFile
ClosedPublic
Actions

Authored by qi437103 on Aug 27 2016, 3:40 PM.

Details

Reviewers

mwolff
kfunk

Group Reviewers

KDevelop

Commits

R32:42fa01d4023d: LLDB/GDB plugin: add support for coredumpctl in unittests, and fix LldbTest…

Summary

In case a coredump file wasn't generated directly, try to invoke coredumpctl to get it.
Also, this patch fixes debug session hanging on starting state when use LLDB as backend.

Test Plan

GdbTest::testCoreFile and LldbTest::testCoreFile

Diff Detail

Repository

R32 KDevelop

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

qi437103 updated this revision to Diff 6321.Aug 27 2016, 3:40 PM

qi437103 retitled this revision from to LLDB/GDB plugin: add support for coredumpctl in unittests, and fix LldbTest::testCoreFile.

qi437103 updated this object.

qi437103 edited the test plan for this revision. (Show Details)

qi437103 added a reviewer: kfunk.

Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptAug 27 2016, 3:40 PM

qi437103 added a reviewer: KDevelop.Aug 27 2016, 3:40 PM

seems to be fine to me, thanks!

debuggers/lldb/unittests/test_lldb.cpp
1323	can we share that code somewhere? but not that important

This revision is now accepted and ready to land.Sep 5 2016, 3:07 PM

qi437103 added inline comments.Sep 5 2016, 3:21 PM

debuggers/lldb/unittests/test_lldb.cpp
1323	AFAIK, it's only used in gdb and lldb unit tests. Sharing it seems a bit overkill to me.

Closed by commit R32:42fa01d4023d: LLDB/GDB plugin: add support for coredumpctl in unittests, and fix LldbTest… (authored by qi437103). · Explain WhySep 5 2016, 3:21 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			debuggers/common/midebugsession.h (7 lines)
M			debuggers/common/midebugsession.cpp (24 lines)
M			debuggers/gdb/debugsession.h (4 lines)
M			debuggers/gdb/debugsession.cpp (30 lines)
M			debuggers/gdb/unittests/test_gdb.cpp (14 lines)
M			debuggers/lldb/debugsession.h (7 lines)
M			debuggers/lldb/debugsession.cpp (37 lines)
M			debuggers/lldb/unittests/debugees/CMakeLists.txt (2 lines)
M			debuggers/lldb/unittests/test_lldb.cpp (24 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	6321	a56cee9		Aug 27 2016, 3:40 PM	★	★
Diff 2	6450	3bf6698	rKDEVELOP42fa01d4023d49f40d54dd39cdcd874d5af39936	Sep 5 2016, 3:21 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
7de9baa4b440	1c7ee9d15719	a56cee976ac4	Peifeng Yu	LLDB/GDB plugin: add support for coredumpctl in unittests, and fix LldbTest… (Show More…)	Aug 27 2016, 3:24 PM