Replace KLocalSocket with QLocalSocket
ClosedPublic
Actions

Authored by nicolasfella on Dec 16 2019, 12:48 AM.

Details

Reviewers

dfaure

Group Reviewers

Frameworks

Commits

R241:28da79f2119e: Replace KLocalSocket with QLocalSocket

Summary

As described in T12010.

AFAIU the QTcpSocket path was only used for Windows, but since QLocalSocket supports Windows we can just use that.

This is entirely untested on Windows though. @vonreth @cullmann can you give this a try?

Test Plan

Did some SFTP stuff in Dolphin.
No new tests fail

Repository

R241 KIO

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

nicolasfella requested review of this revision.Dec 16 2019, 12:48 AM

Let's give this a try. In the absence of human testers on Windows, CI will tell us...

This revision is now accepted and ready to land.Apr 15 2020, 7:57 AM

This revision was automatically updated to reflect the committed changes.

It built but apparently the unittests for KIO are disabled on CI :(

		Path
M		autotests/CMakeLists.txt (2 lines)
D	M	autotests/klocalsocketservertest.h (51 lines)
D	M	autotests/klocalsocketservertest.cpp (311 lines)
D	M	autotests/klocalsockettest.h (48 lines)
D	M	autotests/klocalsockettest.cpp (249 lines)
M		src/core/CMakeLists.txt (3 lines)
M		src/core/connection.cpp (4 lines)
M		src/core/connectionbackend.cpp (126 lines)
M		src/core/connectionbackend_p.h (16 lines)
M		src/core/connectionserver.cpp (6 lines)
D	M	src/core/klocalsocket.h (335 lines)
D	M	src/core/klocalsocket.cpp (228 lines)
D	M	src/core/klocalsocket_p.h (78 lines)
D	M	src/core/klocalsocket_unix.cpp (424 lines)
D	M	src/core/klocalsocket_win.cpp (53 lines)