feat: add Control file watcher
ClosedPublic
Actions

Authored by romangg on Dec 16 2019, 12:09 AM.

Details

Reviewers

None

Group Reviewers

Plasma

Commits

R104:ee2f99d98b47: feat: add Control file watcher

Summary

A simple QFileSystemWatcher is added to Control objects that can be activated
on demand.

On change the Control::changed signal is emitted.

Test Plan

Compiles.

Repository

R104 KScreen

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

romangg requested review of this revision.Dec 16 2019, 12:09 AM

Make sure we only set the file watcher once and connect output control file changes to config control file changes.

Integrate into daemon.

This revision was not accepted when it landed; it landed in state Needs Review.Dec 25 2019, 3:21 PM

This revision was automatically updated to reflect the committed changes.

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	71639	a73b502		Dec 16 2019, 12:09 AM	★	★
Diff 2	71640	a73b502	Make sure we only set the file watcher once.	Dec 16 2019, 12:19 AM	★	★
Diff 3	71641	a73b502	Integrate into daemon.	Dec 16 2019, 12:37 AM	★	★
Diff 4	72170	6ac5ae0	R104:ee2f99d98b47c11c2969a16f83d84b760d8fefad	Dec 25 2019, 3:21 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
bf7d7089b710	ed47b4de90cc	a73b502943e6	Roman Gilg	feat: add Control file watcher (Show More…)	Dec 16 2019, 12:08 AM

Status	Author	Revision
Closed	romangg	D26038 feat(kcm): add option for auto rotation
Closed	romangg	D26037 feat(kded): add orientation sensor
Closed	romangg	D26033 feat: add Control file watcher
Closed	romangg	D26032 feat: add Control API for auto rotation
Closed	romangg	D26031 feat: access outputs controls through config control
Closed	romangg	D26030 feat: read/write output control files
Closed	romangg	D26028 refactor(kcm): move rotation buttons in own module
Closed	romangg	D26027 refactor: make Globals a namespace
Closed	romangg	D26026 refactor: let Control be a QObject
Closed	romangg	D26281 feat: add auto rotate and tablet mode information