Differential D26031

feat: access outputs controls through config control
ClosedPublic
Actions

Authored by romangg on Dec 15 2019, 11:35 PM.

Details

Reviewers
None
Group Reviewers
Plasma
Commits
R104:843baebaeb4e: feat: access outputs controls through config control
Summary

Compositing output controls for all outputs into config control objects allows
writing and reading values according to the retention setting.

Test Plan

Compiles.

Diff Detail

Repository
R104 KScreen
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
romangg created this revision.Dec 15 2019, 11:35 PM
Restricted Application added a project: Plasma. · View Herald TranscriptDec 15 2019, 11:35 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
romangg requested review of this revision.Dec 15 2019, 11:35 PM
davidedmundson added a subscriber: davidedmundson.Dec 17 2019, 1:22 PM

Why do we need to compare names as well as ID?

romangg added a comment.Dec 17 2019, 1:33 PM
In D26031#579232, @davidedmundson wrote:

Why do we need to compare names as well as ID?

The id is the output hash which can be either calculated from its name or edid. If you have two of the same output models that have the same edid you can't distinguish them. The name contains the port the output is connected with.

This revision was not accepted when it landed; it landed in state Needs Review.Dec 25 2019, 3:09 PM
Closed by commit R104:843baebaeb4e: feat: access outputs controls through config control (authored by romangg). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mcommon/control.h (11 lines)
Mcommon/control.cpp (37 lines)

Diff 72167

View Options

common/control.h

Loading...
View Options

common/control.cpp

Loading...