refactor: make Globals a namespace
ClosedPublic
Actions

Authored by romangg on Dec 15 2019, 8:57 PM.

Details

Reviewers

davidedmundson

Group Reviewers

Plasma

Commits

R104:f40df0e64e4f: refactor: make Globals a namespace

Summary

Globals does not need to be a class. This simplifies working with it.

Test Plan

Compiles.

Repository

R104 KScreen

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

romangg requested review of this revision.Dec 15 2019, 8:57 PM

This revision is now accepted and ready to land.Dec 15 2019, 9:13 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			common/globals.h (12 lines)
M			common/globals.cpp (12 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	71630	82e6488		Dec 15 2019, 8:57 PM	★	★
Diff 2	72162	e5abdd2	R104:f40df0e64e4f774fd85e044d571c173b4b37a25b	Dec 25 2019, 2:56 PM	★	★