Differential D26025

SelectSizeTypeComboBox: Use KiB/MiB/GiB quantifiers for clarity
ClosedPublic
Actions

Authored by aspotashev on Dec 15 2019, 8:25 PM.

Details

Reviewers
kde-pim
winterz
Commits
R91:139114b2bbec: SelectSizeTypeComboBox: Use KiB/MiB/GiB quantifiers for clarity
Summary

Binary SI units are used in Sieve, see
https://tools.ietf.org/html/rfc5228#section-2.4.1

Test Plan

it compiles

Diff Detail

Repository
R91 PIM: Sieve Handling Library
Branch
pow2
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 19896
Build 19914: arc lint + arc unit
aspotashev created this revision.Dec 15 2019, 8:25 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptDec 15 2019, 8:25 PM
aspotashev requested review of this revision.Dec 15 2019, 8:25 PM
winterz accepted this revision.Mar 1 2020, 9:19 PM
winterz added a subscriber: winterz.

I see no reason not to commit this.
consistency is good.

This revision is now accepted and ready to land.Mar 1 2020, 9:19 PM
aspotashev closed this revision.May 23 2020, 11:57 AM

Revision Contents
Changeset List

Diff 71627

View Options

src/ksieveui/autocreatescripts/sieveconditions/widgets/selectsizetypecombobox.cpp

Loading...