Differential D26018

[Notifications KCM] Add KeySequenceItem for do not disturb shortcut
ClosedPublic
Actions

Authored by broulik on Dec 15 2019, 1:35 PM.

Details

Reviewers
davidedmundson
ngraham
Group Reviewers
Plasma
VDG
Commits
R119:35e8cb70c0c0: [Notifications KCM] Add KeySequenceItem for do not disturb shortcut
Test Plan

Not a huge fan of the code duplication there..

Needs D26013 and D26016 to fully work

Diff Detail

Repository
R119 Plasma Desktop
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.Dec 15 2019, 1:35 PM
Restricted Application added a project: Plasma. · View Herald TranscriptDec 15 2019, 1:35 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Dec 15 2019, 1:35 PM
ngraham added a subscriber: ngraham.Dec 15 2019, 2:31 PM

+1 on adding this, for sure. I think it's nice when a feature's shortcut is exposed like this.

kcms/notifications/package/contents/ui/main.qml
100

Maybe "Toggle with:"?

davidedmundson accepted this revision.Dec 18 2019, 1:14 PM
This revision is now accepted and ready to land.Dec 18 2019, 1:14 PM
davidedmundson added a comment.Dec 18 2019, 1:15 PM

That's accepting purely code-wise.
Please make sure the text is approved by VDG people before pushing.

ngraham accepted this revision.Dec 18 2019, 1:28 PM

As discussed in chat:

i18nc("Turn do not disturb mode on/off with keyboard shortcut", "Toggle with:")
Closed by commit R119:35e8cb70c0c0: [Notifications KCM] Add KeySequenceItem for do not disturb shortcut (authored by broulik). · Explain WhyDec 18 2019, 1:46 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 71599

View Options

kcms/notifications/CMakeLists.txt

Loading...
View Options

kcms/notifications/kcm.h

Loading...
View Options

kcms/notifications/kcm.cpp

Loading...
View Options

kcms/notifications/package/contents/ui/main.qml

Loading...