[KeySequenceHelper] Grab actual window when embedded
ClosedPublic

Authored by broulik on Dec 15 2019, 11:24 AM.

Details

Summary

When used in a KCM which uses QQuickWidget it needs to enable grab on the render window and not the embedded container.

Test Plan
  • Put KeySequence thing in a KCM, I could now type a shortcut which was occupied by someone else
  • Still works in system settings (renderWindowFor annoyingly returns nullptr instead of the same window if it isn't redirected so I had to check)

For simplicity I store the window in a QPointer to ungrab the same thing I grabbed before

Diff Detail

Repository
R296 KDeclarative
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.Dec 15 2019, 11:24 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptDec 15 2019, 11:24 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
broulik requested review of this revision.Dec 15 2019, 11:24 AM
davidre accepted this revision.Dec 16 2019, 12:58 PM
This revision is now accepted and ready to land.Dec 16 2019, 12:58 PM
This revision was automatically updated to reflect the committed changes.