Before this patch, the outline of the rubberband selection control was down and to the right half a pixel too far.
This wasn't visible at 1x scaling because of the lack of antialiasing, but resulted in the top/left being too thin and bottom/right being too thick on high DPI displays.
To fix the issue, I enabled antialiasing and moved all sides inwards by half a pixel so that the outline would be pixel perfect.
I also added a function to get a QRectF with the correct size and position for rectangles with pen strokes.
Details
Details
- Reviewers
hpereiradacosta broulik - Group Reviewers
VDG Breeze Plasma - Commits
- R31:80650e0e873d: Fix rubberband selection outline position
- Open dolphin and make a selection with the mouse
- Go to a Folder View Plasma widget and make a selection with the mouse
2x scaling
before:
after:
3x scaling
before:
after:
Diff Detail
Diff Detail
- Repository
- R31 Breeze
- Branch
- fix-rubberband (branched from master)
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 19857 Build 19875: arc lint + arc unit
Comment Actions
Fix is legit. Thanks !
I would avoid changing the alpha of the color though because: it makes no difference, and it is unrelated to the issue. Should be a different commit (which you can do without review if you really think it is important)
Fix it then ship it !
Comment Actions
It's not important, it's just nice if I can move it slightly up to an easy to express percentage (19.60784313725490% vs 20%)