KFilePlacesModel: properly parent tagsLister to avoid memleak. Introduced with D7700
AbandonedPublic
Actions

Authored by chehrlic on Dec 14 2019, 4:29 PM.

Details

Summary

HTTP ioslave: call correct base class in virtual_hook(). The base of HTTP ioslave is TCPSlaveBase, not SlaveBase.

KRemoteEncoding::encoding: don't return temporary. Found with clazy.

Repository

R241 KIO

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 19841
Build 19859: arc lint + arc unit

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

chehrlic requested review of this revision.Dec 14 2019, 4:29 PM

			Path	Packages
M			src/core/kremoteencoding.cpp (4 lines)
M			src/filewidgets/kfileplacesmodel.cpp (2 lines)
M			src/ioslaves/http/http.cpp (2 lines)

Commit	Tree	Parents	Author	Summary	Date
7151454bd405	8b6768a6a66e	1e36a33c6430	Christian Ehrlicher	KRemoteEncoding::encoding: don't return temporary. Found with clazy.	Dec 14 2019, 4:25 PM
1e36a33c6430	cb7320d5c976	9065b39880c9	Christian Ehrlicher	HTTP ioslave: call correct base class in virtual_hook(). The base of HTTP… (Show More…)	Dec 14 2019, 4:24 PM
9065b39880c9	28d929f59b2d	5a8113d3279c	Christian Ehrlicher	KFilePlacesModel: properly parent tagsLister to avoid memleak. Introduced with… (Show More…)	Dec 14 2019, 4:23 PM

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	71527	5a8113d		Dec 14 2019, 4:29 PM	★	★