A device doesn't usually have a URL so we need to actutally check the underlying device (e.g. StorageAccess or NetworkShare) for whether it is supported.
Details
Details
- Reviewers
dfaure ngraham bruns - Group Reviewers
Frameworks - Commits
- R241:3a6e3f927111: [KFilePlacesModel] Fix supported scheme check for devices
- kdialog --getopenfilename ~ now has my mounted ISOs and external storage now
- didn't test with CD drives or network shares
- KFilePlaces tests stil pass
Diff Detail
Diff Detail
- Repository
- R241 KIO
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
src/filewidgets/kfileplacesmodel.cpp | ||
---|---|---|
758 | you have dropped the allowedHere check. Probably just if (!allowedHere) continue. And for reasons unknown to me, tags: is not filtered per app - move the allowedHere check to the very beginning of the while(...) loop. | |
759 | Does KFilePlacesItem have a move constructor? You can do the heap allocation then only if necessary. |