Differential D25983

Update size hint when font changes
ClosedPublic
Actions

Authored by broulik on Dec 14 2019, 10:47 AM.

Details

Reviewers
ngraham
Group Reviewers
Plasma
Commits
R858:51871406787d: Update size hint when font changes
Summary

Ensures controls update their size when font changes.
The Labels inside would but the control around them not, leading to broken rendering until causing it to update by interacting with it.
It has to be queued for some reason or else by the time the signal is invoked, the style hasn't caught up yet.

Test Plan

*Changed from 10pt to 12pt
Before:
The one I hovered updated half-way


After:
All controls update immediately

Diff Detail

Repository
R858 Qt Quick Controls 2: Desktop Style
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Dec 14 2019, 10:47 AM
Restricted Application added a project: Plasma. · View Herald TranscriptDec 14 2019, 10:47 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Dec 14 2019, 10:47 AM
ngraham accepted this revision.Dec 14 2019, 10:50 AM
ngraham added a subscriber: ngraham.

Yup.

This revision is now accepted and ready to land.Dec 14 2019, 10:50 AM
Closed by commit R858:51871406787d: Update size hint when font changes (authored by broulik). · Explain WhyDec 15 2019, 10:40 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mplugin/kquickstyleitem.cpp (2 lines)

Diff 71578

View Options

plugin/kquickstyleitem.cpp

Loading...