Differential D25978

Don't hardcode the margin of the CardsListView
ClosedPublic
Actions

Authored by apol on Dec 14 2019, 8:56 AM.

Details

Reviewers
mart
Group Reviewers
Kirigami
Commits
R169:2757a17bb089: Don't hardcode the margin of the CardsListView
Summary

Use the left/rightMargin properties with a default value, in case it makes
sense to override it.

Test Plan

Used it on okular, works correctly

Diff Detail

Repository
R169 Kirigami
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
apol created this revision.Dec 14 2019, 8:56 AM
Restricted Application added a project: Kirigami. · View Herald TranscriptDec 14 2019, 8:56 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
apol requested review of this revision.Dec 14 2019, 8:56 AM
davidedmundson added a subscriber: davidedmundson.Dec 14 2019, 10:10 AM

Makes sense, but I don't understand how this helps, given the path is "private/" ?

apol added a comment.Dec 14 2019, 11:13 AM

The path is private but the class is directly inherited. 🤷

mart accepted this revision.Dec 14 2019, 11:55 AM
This revision is now accepted and ready to land.Dec 14 2019, 11:55 AM
Closed by commit R169:2757a17bb089: Don't hardcode the margin of the CardsListView (authored by apol). · Explain WhyDec 14 2019, 11:58 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 71504

View Options

src/controls/private/CardsListViewPrivate.qml

Loading...