[nightcolor] Use a dedicated class for detection of system clock changes
ClosedPublic

Authored by zzag on Dec 13 2019, 6:00 PM.

Details

Summary

The ClockSkewNotifier provides a convenient way for monitoring system
clock changes. One of the key ideas was to hide platform details from
users of the class. This allows us to add a QTimer fallback path for
operating systems that don't provide anything to detect system clock
changes.

In long term, I would like to move the new class to Frameworks.

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zzag created this revision.Dec 13 2019, 6:00 PM
Restricted Application added a project: KWin. · View Herald TranscriptDec 13 2019, 6:00 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.Dec 13 2019, 6:00 PM
davidedmundson added inline comments.
colorcorrection/clockskewnotifier.h
3

I know you tried to get it into frameworks once.

I think you were to quick to abandon it. Someone only asked "where will you use it?" You can now point here (and maybe port p-w/dataengines/time :) )

davidedmundson accepted this revision.Dec 23 2019, 1:34 PM
This revision is now accepted and ready to land.Dec 23 2019, 1:34 PM
zzag added inline comments.Dec 23 2019, 3:54 PM
colorcorrection/clockskewnotifier.h
3

Someone only asked "where will you use it?

Well, it was more like "where do you use it right now?"

https://phabricator.kde.org/D24629#546912

This revision was automatically updated to reflect the committed changes.
victorr added a subscriber: victorr.Jan 9 2020, 8:03 PM
This comment was removed by victorr.