[applets/taskmanager] Keep tooltip open when clicking on a thumbnail
AbandonedPublic

Authored by ngraham on Dec 13 2019, 2:22 PM.

Details

Reviewers
hein
ndavis
Group Reviewers
Plasma
VDG
Summary

The tooltip already stays open when you click on the close button, to allow you to close
multiple windows in rapid succession. This patch adopts that behavior for when clicking
on the thumbnail itself, in aid of the use case where you want to bring multiple windows
forward in rapid succession.

BUG: 414976
FIXED-IN: 5.18.0

Test Plan
  • Turn on tooltips if they're off
  • Open multiple windows such that one of yout Task Manager items becomes grouped
  • Hover over the grouped item
  • Click on multiple windows to bring them all forward quickly

Diff Detail

Repository
R119 Plasma Desktop
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 19794
Build 19812: arc lint + arc unit
ngraham created this revision.Dec 13 2019, 2:22 PM
Restricted Application added a project: Plasma. · View Herald TranscriptDec 13 2019, 2:22 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Dec 13 2019, 2:22 PM
ndavis accepted this revision.Dec 15 2019, 2:00 AM
ndavis added a subscriber: ndavis.

+1

This revision is now accepted and ready to land.Dec 15 2019, 2:00 AM

There's a huge difference compared to close.

With the thumbail case, it's quite common that your next action is to want to interact with the window that's under the thumbnail.

With close that isn't the case.

Given this was added very explicitly (8e1e22bc25315846baf2888a77f86182f7dde34d) I strongly expect this behaviour will will increase clicks in the common case to reduce a click in a super niche case.

I agree. The tooltips get in the way far too often as they are, so making them stay unnecessarily would be annoying.

Maybe it could stay open after click only for the case where it's a tooltip for a grouped item and there are multiple windows in it? IIRC this is what Windows does, now that I think about it.

Maybe it could stay open after click only for the case where it's a tooltip for a grouped item and there are multiple windows in it? IIRC this is what Windows does, now that I think about it.

But even so, which case which is more likely:

A user wants to interact with a recently clicked window that overlaps with the tooltip
A user wants to open 2 windows.

Both are annoying, and both are resolved with an additional click.

ngraham abandoned this revision.Dec 15 2019, 10:54 AM

All right.