The new applet allows to temporarily disable Night Color, for example if
one wants to edit a video or an image.
BUG: 400418
ngraham | |
davidedmundson |
Plasma | |
VDG |
The new applet allows to temporarily disable Night Color, for example if
one wants to edit a video or an image.
BUG: 400418
No Linters Available |
No Unit Test Coverage |
Buildable 19792 | |
Build 19810: arc lint + arc unit |
This is fantastic! My on UI suggestion is to only the applet in the system tray (when using "Auto" visibility) only when Night Color is actually activated or activating. People who want it in their tray all the time can manually set it to "shown". The one exception would be that when Night Color is is using the "Constant" mode, the applet should always be visible in the tray when using "Auto" visibility.
Hmm, that last change broke clicking on the applet. Now it does nothing. +1 for the general ideal behind it though.
Revert applet visibility changes.
Unfortunately, this may cause unnecessary shuffling of system tray items.
Thanks, that fixed it. I haven't noticed any shifting of the plasmoid in the system tray, but if you want to minimize that, you can add X-Plasma-NotificationAreaCategory=SystemServices to the metadata.desktop file. See D11352 for more details.
Does it make sense to dump the C++ classes in libcolorcorrect?
It has an import for use client side usage for the KCM, his is just another client, especially inhibitor.
applets/nightcolor/package/contents/ui/main.qml | ||
---|---|---|
97 | I don't think we have an official QML coding guideline, but convention throughout plasma has been to put {} for single line if statements. | |
99 | Should plasmoid.removeAction("configure"); be in an else? |
Does it make sense to dump the C++ classes in libcolorcorrect?
I think it will be better to keep them here for now. Once somebody else needs one of them, we can move them to libcolorcorrect (bad name).
applets/nightcolor/package/contents/ui/main.qml | ||
---|---|---|
99 | Could you please explain why it needs to be in an else? |
applets/nightcolor/package/contents/ui/main.qml | ||
---|---|---|
99 | I assumed it was trying to remove the action created here: I see now that "configure" on the setAction is the icon name and this is removing a different action |