Sync dark theme preference for GTK3 applications
ClosedPublic
Actions

Authored by gikari on Dec 13 2019, 12:37 PM.

Details

Reviewers

apol
cblack
broulik

Group Reviewers

VDG

Maniphest Tasks

T10611: Set options for GTK apps in the respective KCMs

Commits

R99:99c72b4b9581: Sync dark theme preference for GTK3 applications

Summary

Previously preference of dark GTK3 theme was set by checkbox in GTK KCM. Now, the checkbox is removed and preference is set according to color scheme, the user set in Colors KCMm, using the same heuristic, used for filter combobox in that KCM.

This makes sense, because, suppose the user set Adwaita GTK3 theme, and their color scheme is something dark. Therefore their overall theme is supposedly dark, so Adwaita needs to be dark too.

Note, however, that this preference is somewhat buggy. It does not work in flatpak apps, it can't be autoreloaded with xsettingsd, and also it is applied after some time has passed (this is hypothetical). You can check these statements, using the present checkbox in GTK KCM.

Depends on D25872

Test Plan

Apply Adwaita GTK3 Theme
Reload kded5
Apply dark color scheme
Wait some time
(Re)open GTK3 app
App should use Dark color scheme
Apply light color scheme
Wait some time
Reopen GTK3 app
App should use Light color scheme

Diff Detail

Repository

R99 KDE Gtk Configuration Tool

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

gikari created this revision.Dec 13 2019, 12:37 PM

Restricted Application added a project: Plasma. · View Herald TranscriptDec 13 2019, 12:37 PM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

gikari requested review of this revision.Dec 13 2019, 12:37 PM

Harbormaster completed remote builds in B19782: Diff 71424.Dec 13 2019, 12:37 PM

gikari edited the test plan for this revision. (Show Details)Dec 13 2019, 12:38 PM

gikari added a reviewer: VDG.

gikari added a task: T10611: Set options for GTK apps in the respective KCMs.Dec 14 2019, 10:39 AM

gikari mentioned this in T10611: Set options for GTK apps in the respective KCMs.

Works perfectly fine for me without waiting.

Code looks fine to me.

For flatpaks not respecting the setting preference, have you checked that the dark theme variant is installed? f-d-o runtime doesn't offer an Adwaita-dark stub, while GNOME runtime does.

As for xsettingsd, I'm not sure if it synchronises the dark theme preference. That doesn't appear to be in the xsettings spec afaik.

This revision is now accepted and ready to land.Dec 14 2019, 4:30 PM

In D25945#577677, @cblack wrote:

For flatpaks not respecting the setting preference, have you checked that the dark theme variant is installed?

Yes, I have installed the theme. But after changing the value in gtk configs nothing happens. It could also be the result of my local setup bugs (because as the @GB_2 said, the patch works for him flawlessly). So I think he (or someone else) should test it.

There is a bug about flatpak not using selected GTK theme on X11. It is because it can only be done by letting the xsettingd to control the theme of the flatpak app. So, to test dark-theme preference sync you need to add to the ~/.config/xsettingsd/xsettingsd.conf this line:

Net/ThemeName "Adwaita"

check the dark theme preference checkbox in old GTK KCM and then relaunch xsettingsd. The flatpak app should be dark.

In D25945#577731, @gikari wrote:
In D25945#577677, @cblack wrote:

For flatpaks not respecting the setting preference, have you checked that the dark theme variant is installed?

Yes, I have installed the theme. But after changing the value in gtk configs nothing happens. It could also be the result of my local setup bugs (because as the @GB_2 said, the patch works for him flawlessly). So I think he (or someone else) should test it.

There is a bug about flatpak not using selected GTK theme on X11. It is because it can only be done by letting the xsettingd to control the theme of the flatpak app. So, to test dark-theme preference sync you need to add to the ~/.config/xsettingsd/xsettingsd.conf this line:
Net/ThemeName "Adwaita"
check the dark theme preference checkbox in old GTK KCM and then relaunch xsettingsd. The flatpak app should be dark.

No, looks like there is no way to make this option work for Flatpak apps, because it can't be set with xsettingsd.

apol accepted this revision.Dec 18 2019, 5:05 PM

Rebase on master

Harbormaster completed remote builds in B20028: Diff 71806.Dec 18 2019, 5:18 PM

@broulik do I need your revision to land this?

@apol is the maintainer and @broulik hasn't raised any objections, so I'd say you're good to go.

Closed by commit R99:99c72b4b9581: Sync dark theme preference for GTK3 applications (authored by gikari). · Explain WhyDec 18 2019, 5:26 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			CMakeLists.txt (1 line)
M			kded/configvalueprovider.h (1 line)
M			kded/configvalueprovider.cpp (16 lines)
M			kded/gtkconfig.h (1 line)
M			kded/gtkconfig.cpp (9 lines)
M			src/appearancegtk3.h (2 lines)
M			src/appearancegtk3.cpp (19 lines)
M			src/appearencegtk.h (2 lines)
M			src/appearencegtk.cpp (10 lines)
M			src/gtkconfigkcmodule.cpp (6 lines)
M			src/ui/gui.ui (10 lines)
M			tests/configsavetest.cpp (5 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	71424	9680ae6		Dec 13 2019, 12:36 PM	★	★
Diff 2	71806	13c4eee	Rebase on master	Dec 18 2019, 5:18 PM	★	★
Diff 3	71808	13c4eee	R99:99c72b4b958124fec004297adbdcb4583916dc15	Dec 18 2019, 5:26 PM	★	★