Differential D25940

Add support for custom display components to Action
ClosedPublic
Actions

Authored by ahiemstra on Dec 13 2019, 9:47 AM.

Details

Reviewers

mart

Group Reviewers

Kirigami

Commits

R169:22d31898ae0b: Add support for custom display components to Action

Summary

This adds a "displayComponent" property to Action, which allows specifying a
component to use when displaying an Action. Support is added to ActionToolBar
and ActionsMenu for displaying these custom components.

Demo:

Test Plan

ActionToolBar and ActionsMenu still work the same. The new Action Tool Bar page
in Kirigami Gallery displays the custom components. (See D25941)

Diff Detail

Repository

R169 Kirigami

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

ahiemstra created this revision.Dec 13 2019, 9:47 AM

Restricted Application added a project: Kirigami. · View Herald TranscriptDec 13 2019, 9:47 AM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

ahiemstra requested review of this revision.Dec 13 2019, 9:47 AM

Harbormaster completed remote builds in B19773: Diff 71415.Dec 13 2019, 9:47 AM

ahiemstra edited the test plan for this revision. (Show Details)Dec 13 2019, 9:54 AM

ahiemstra edited the summary of this revision. (Show Details)Dec 13 2019, 9:57 AM

mart accepted this revision.Dec 13 2019, 10:03 AM

mart added a subscriber: mart.

mart added inline comments.

src/controls/Action.qml
151	@since 2.12 @since 5.65

This revision is now accepted and ready to land.Dec 13 2019, 10:03 AM

Add missing @since

Harbormaster completed remote builds in B19776: Diff 71418.Dec 13 2019, 10:13 AM

ahiemstra marked an inline comment as done.Dec 13 2019, 10:14 AM

ahiemstra mentioned this in D25941: Add a page to display ActionToolBar and some of its features.

Closed by commit R169:22d31898ae0b: Add support for custom display components to Action (authored by ahiemstra). · Explain WhyDec 13 2019, 4:38 PM

This revision was automatically updated to reflect the committed changes.

ahiemstra mentioned this in R1014:9f3a617da366: Add a page to display ActionToolBar and some of its features.Jan 8 2020, 7:25 PM

Revision Contents
Changeset List

			Path	Packages
M			src/controls/Action.qml (8 lines)
M			src/controls/ActionToolBar.qml (56 lines)
M			src/controls/private/ActionToolBarLayoutDetails.qml (50 lines)
M			src/controls/private/ActionsMenu.qml (5 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	71415	4817761		Dec 13 2019, 9:47 AM	★	★
Diff 2	71418	4817761	- Add missing @since	Dec 13 2019, 10:13 AM	★	★
Diff 3	71459	3aa7f59	R169:22d31898ae0b5d86fb39a5704716e2cf1faf82a7	Dec 13 2019, 4:38 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
927dcd2c6179	0dd0d4a271af	d5e7a770fdfc	Arjen Hiemstra	Add missing @since	Dec 13 2019, 10:13 AM
d5e7a770fdfc	7833a9a106de	4e518bcd23be	Arjen Hiemstra	Add support for custom display components to Action (Show More…)	Dec 13 2019, 9:38 AM
4e518bcd23be	462560d54a05	43fbd6cd65c5	Arjen Hiemstra	Support custom display components for Actions in ActionToolBar	Dec 13 2019, 9:38 AM
43fbd6cd65c5	c8384b48f8f0	48177613f2ca	Arjen Hiemstra	Add displayComponent to Action	Dec 12 2019, 4:56 PM