[Notifications] Add hint for a notification being response to explicit user interaction
ClosedPublic

Authored by broulik on Dec 12 2019, 9:14 PM.

Details

Summary

This can be useful for notifications that confirm direct user interaction, such as successful Bluetooth pairing, Screenshot creation, or plasmoid removal.
It only overrules filtering based on urgency, disabling notifications for that application altogether will still hide them.
Such a notification also won't increase the unread counter as it can be assumed when they do something, e.g. click on "Pair", they will notice that the pairing progress dialog went away and a confirmation notification is shown.

Test Plan

Enabled dnd mode, notify-send foo bar -h string:x-kde-user-action:true and it showed up regardless

Diff Detail

Repository
R120 Plasma Workspace
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.Dec 12 2019, 9:14 PM
Restricted Application added a project: Plasma. · View Herald TranscriptDec 12 2019, 9:14 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Dec 12 2019, 9:14 PM

x-kde-show-when-in-do-not-disturb-mode maybe? Might be nice to reference the feature itself in the keyword since "inhibited" is rather vague.

Internally it uses "inhibited" for that everywhere

Yeah but this is a user-facing thing (well, sort of user-facing).

Eh, your choice.

How is it, though? It is an internal hint on some DBus method no user will ever see. Internally it's all things like notificationsInhibitedUntil, even the (public) DBus API says "Inhibited"

All right, you've convinced me. :)

It was suggested to make it more semantic, i.e. be about "this is feedback for user-initiated task" which will then imply showing in dnd mode. Suggestions on how to phrase that as a key name?

broulik updated this revision to Diff 71877.Dec 20 2019, 11:02 AM
broulik retitled this revision from [Notifications] Add hint for showing a notification even in do not disturb mode to [Notifications] Add hint for a notification being response to explicit user interaction.
broulik edited the summary of this revision. (Show Details)
broulik edited the test plan for this revision. (Show Details)
  • Make more generic and implicit
davidedmundson accepted this revision.Dec 20 2019, 11:55 AM
davidedmundson added a subscriber: davidedmundson.

I thought you were going to call it UserActionFeedback?

This revision is now accepted and ready to land.Dec 20 2019, 11:55 AM

I thought you were going to call it UserActionFeedback?

You said "user-action works"

This revision was automatically updated to reflect the committed changes.