Differential D25928

Port doc generator to python 3
ClosedPublic
Actions

Authored by ognarb on Dec 12 2019, 4:26 PM.

Details

Reviewers
ltoscano
yurchor
adrianchavesfernandez
Commits
R184:325f833fa90f: Port doc generator to python 3
Summary

Python 2 is now in end of life. Port to python 3

Test Plan

Succesfull generated en,fr,uk for project calligra and kdegraphics

Diff Detail

Repository
R184 Documentation Website (docs.kde.org)
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ognarb created this revision.Dec 12 2019, 4:26 PM
Restricted Application added a project: Documentation. · View Herald TranscriptDec 12 2019, 4:26 PM
Restricted Application added a subscriber: kde-doc-english. · View Herald Transcript
ognarb requested review of this revision.Dec 12 2019, 4:26 PM
yurchor accepted this revision.Dec 12 2019, 4:30 PM
yurchor added a subscriber: yurchor.

Thanks. texlive-latex-extra is not installed (if it's a Debian-based distro).

This revision is now accepted and ready to land.Dec 12 2019, 4:30 PM
ltoscano added a comment.Dec 12 2019, 4:32 PM

If it is going to be python3-only, then the shebang lines should be changed as well.

Have you tested it with Python 3.5, which is the version we have on the library, the build server?

ltoscano requested changes to this revision.Dec 12 2019, 4:33 PM
This revision now requires changes to proceed.Dec 12 2019, 4:33 PM
ognarb updated this revision to Diff 71727.Dec 17 2019, 3:37 PM
  • Add python 3 shellbang
  • Tested with python 3.5
ltoscano added a comment.Jan 11 2020, 1:13 PM

Accepted if you amend the commit message; the full log from the build generation is probably overkill.

ognarb edited the summary of this revision. (Show Details)Jan 11 2020, 2:50 PM
ognarb edited the test plan for this revision. (Show Details)
ltoscano accepted this revision.Jan 11 2020, 3:44 PM

Thanks!

This revision is now accepted and ready to land.Jan 11 2020, 3:44 PM
Closed by commit R184:325f833fa90f: Port doc generator to python 3 (authored by ognarb). · Explain WhyJan 11 2020, 3:57 PM
This revision was automatically updated to reflect the committed changes.
ognarb added a comment.Jan 11 2020, 3:57 PM

Thanks for the review :)

Revision Contents
Changeset List

PathPackages
Mkdedocgen.py (2 lines)
Mkdedocs/configuration.py (18 lines)
Mkdedocs/docgenerator.py (6 lines)
Mkdedocs/environments.py (9 lines)

Diff 73280

View Options

kdedocgen.py

Loading...
View Options

kdedocs/configuration.py

Loading...
View Options

kdedocs/docgenerator.py

Loading...
View Options

kdedocs/environments.py

Loading...