[PC3] Only show progress bar indicator when the ends won't overlap
ClosedPublic
Actions

Authored by davidedmundson on Dec 12 2019, 4:16 PM.

Details

Reviewers

filipf

Group Reviewers

Plasma

Commits

Summary

If the width is smaller than LeftMargin + Right Margin the two ends
overlap and it looks super weird

Test Plan

Progressbar manual unit test looks sane

Repository

R242 Plasma Framework (Library)

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

davidedmundson requested review of this revision.Dec 12 2019, 4:16 PM

This revision is now accepted and ready to land.Dec 13 2019, 11:23 AM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			src/declarativeimports/plasmacomponents3/ProgressBar.qml (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	71369	fecb716		Dec 12 2019, 4:16 PM	★	★
Diff 2	71425	5172b92	R242:e91ba953eafbbf626368e1f4960a400cbbfd3cb1	Dec 12 2019, 9:18 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
f1d876627ed3	b291a2293497	fecb716b8796	David Edmundson	[PC3] Only show progress bar indicator when the ends won't overlap (Show More…)	Dec 12 2019, 4:15 PM