Polish the reviews UI and presentation
ClosedPublic

Authored by ngraham on Dec 11 2019, 3:31 PM.

Details

Summary

Implement mockups provided by VDG to improve visual appeal of reviews UI. Layout is a bit cramped due to https://bugs.kde.org/show_bug.cgi?id=415677.

Test Plan

Diff Detail

Repository
R134 Discover Software Store
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.Dec 11 2019, 3:31 PM
Restricted Application added a project: Plasma. · View Herald TranscriptDec 11 2019, 3:31 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Dec 11 2019, 3:31 PM
ngraham updated this revision to Diff 71290.Dec 11 2019, 3:47 PM

Fix the rebase

ndavis added a subscriber: ndavis.EditedDec 14 2019, 5:29 AM

I don't find this better than the current form:

I know you can't control the color, but the yellow thumbs up/down emojis are harder to see against the white background than Yes/No text. They also stick out as not looking like real buttons. The Yes/No text at least looks like links that send the intended message to wherever.

I find that the current one takes up too much vertical space and the top line of text blends too much into the review itself. I feel like those issues should be addressed somehow. Maybe this isn't the right way, so suggestions would be appreciated.

I find that the current one takes up too much vertical space and the top line of text blends too much into the review itself. I feel like those issues should be addressed somehow. Maybe this isn't the right way, so suggestions would be appreciated.

I don't think it takes up too much vertical space and I think it uses horizontal space inefficiently.

Here's a suggestion for a way to improve the UI:

Another thing to consider is whether or not the review section in Discover should be kept consistent with the reviews/comments in the new GHNS UI.

ngraham planned changes to this revision.Sat, Dec 28, 5:18 AM

Here's a suggestion for a way to improve the UI:

That looks way better, I'll give that a try.

apol added a comment.Sat, Dec 28, 8:16 PM

I'm not convinced about using emoji in place of icons. Are we sure about that?

I like ndavis's suggestion, but as a delegate, having so many lines could look cluttered.

Should we consider using cards?

ndavis added a comment.EditedSun, Dec 29, 1:33 AM
In D25889#584040, @apol wrote:

I'm not convinced about using emoji in place of icons. Are we sure about that?

I like ndavis's suggestion, but as a delegate, having so many lines could look cluttered.

Should we consider using cards?

Here's one with fewer lines:

Review summary area:

ngraham updated this revision to Diff 72336.Sun, Dec 29, 5:07 PM

Implement VDG mockups

ngraham retitled this revision from Polish the "review this review" UI and presentation to Polish the reviews UI and presentation.Sun, Dec 29, 5:09 PM
ngraham edited the summary of this revision. (Show Details)
ngraham edited the test plan for this revision. (Show Details)

I'll do the change to show the top positive and top negative reviews on the app page in a separate patch once this lands.

apol accepted this revision.Sat, Jan 4, 5:21 PM
apol added inline comments.
discover/qml/ReviewDelegate.qml
188

checked: usefulChoice === ReviewsModel.No

This revision is now accepted and ready to land.Sat, Jan 4, 5:21 PM
ngraham updated this revision to Diff 72758.Sat, Jan 4, 5:30 PM
ngraham marked an inline comment as done.

Address review comment

This revision was automatically updated to reflect the committed changes.