Differential D25888

Support multiple children elements in comment elements
ClosedPublic
Actions

Authored by leinir on Dec 11 2019, 3:28 PM.

Details

Reviewers
ngraham
Group Reviewers
Frameworks
KNewStuff
Commits
R235:268195d2d5e2: Support multiple children elements in comment elements
Summary

This may seem strange, however we are dealing with a situation where we may
receive multiple children subsections (the standard accepts this, and certain
server implementations do do this)

Test Plan

Without patch: Notice that the comments count for the McMohave-circle icons entry in KNewStuff is listed as 175, but that there are only 163 comments shown
With patch: Notice that the count is correct in both instances

Diff Detail

Repository
R235 Attica
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
leinir created this revision.Dec 11 2019, 3:28 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptDec 11 2019, 3:28 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
leinir requested review of this revision.Dec 11 2019, 3:28 PM
leinir edited the test plan for this revision. (Show Details)Dec 11 2019, 3:29 PM
leinir added reviewers: Frameworks, KNewStuff, ngraham.
ngraham accepted this revision.Dec 11 2019, 3:32 PM

Awesome!

This revision is now accepted and ready to land.Dec 11 2019, 3:32 PM
Closed by commit R235:268195d2d5e2: Support multiple children elements in comment elements (authored by leinir). · Explain WhyDec 11 2019, 3:33 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/commentparser.cpp (6 lines)

Diff 71285

View Options

src/commentparser.cpp

Loading...