Add support for sub-comments to the Reviews backend
ClosedPublic

Authored by leinir on Dec 11 2019, 2:56 PM.

Details

Summary

Using a similar style to the comments delegate in KNewStuffQuick, this
adds the functionality for having subcomments in the Reviews model.
The end result is that we no longer have incorrect numbers showing in
Discover, as it now shows all the items returned by the server.

  • Adds a role for the depth of reviews (used for comments on reviews)
  • Adds sub-comments (and set their depth) in the KNS backend's reviews
  • Adapts the ReviewDelegate to have indentation marks (styled like KNSQuick)

BUG: 391191
FIXED-IN: 5.17.0

Test Plan

Without the patch, incorrect numbers of reviews are shown (as no children are shown). With this patch, children are shown (using the same indentation style as used by KNewStuffQuick):

Diff Detail

Repository
R134 Discover Software Store
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
leinir created this revision.Dec 11 2019, 2:56 PM
Restricted Application added a project: Plasma. · View Herald TranscriptDec 11 2019, 2:56 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
leinir requested review of this revision.Dec 11 2019, 2:56 PM
leinir edited the test plan for this revision. (Show Details)Dec 11 2019, 2:57 PM
ngraham accepted this revision.Dec 11 2019, 3:33 PM

Nice!

This revision is now accepted and ready to land.Dec 11 2019, 3:33 PM
ngraham edited the summary of this revision. (Show Details)Dec 11 2019, 3:34 PM
This revision was automatically updated to reflect the committed changes.