Differential D25879

Add an option to enable QML profiling
ClosedPublic
Actions

Authored by ahiemstra on Dec 11 2019, 11:40 AM.

Details

Reviewers
bshah
Group Reviewers
Kirigami
Commits
R1014:693c491bc577: Add an option to enable QML profiling
Summary

This adds a CMake option to enable QML profiler and debugger integration.
This allows running the gallery through the QML profiler, which makes it
simple to profile Kirigami through running Kirigami Gallery.

It is by default set to "ON" because I do not think there really is any
risk related to enabling it.

Test Plan

With the option on, starting Kirigami Gallery from command line will print
"QML debugging is enabled". Without it, no such print happens.

Diff Detail

Repository
R1014 Kirigami Gallery
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ahiemstra created this revision.Dec 11 2019, 11:40 AM
Restricted Application added projects: Plasma, Kirigami. · View Herald TranscriptDec 11 2019, 11:40 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ahiemstra requested review of this revision.Dec 11 2019, 11:40 AM
bshah requested changes to this revision.Dec 11 2019, 11:42 AM
bshah added a subscriber: bshah.
bshah added inline comments.
CMakeLists.txt
33

Commit description and code doesn't match :)

This revision now requires changes to proceed.Dec 11 2019, 11:42 AM
ahiemstra updated this revision to Diff 71264.Dec 11 2019, 11:49 AM
  • Actually set qml profiling to ON by default
ahiemstra marked an inline comment as done.Dec 11 2019, 11:50 AM
ahiemstra added inline comments.
CMakeLists.txt
33

D'oh.

bshah accepted this revision.Dec 11 2019, 11:54 AM
This revision is now accepted and ready to land.Dec 11 2019, 11:54 AM
Closed by commit R1014:693c491bc577: Add an option to enable QML profiling (authored by ahiemstra). · Explain WhyDec 11 2019, 12:46 PM
This revision was automatically updated to reflect the committed changes.
ahiemstra marked an inline comment as done.

Revision Contents
Changeset List

PathPackages
MCMakeLists.txt (2 lines)
Msrc/CMakeLists.txt (3 lines)

Diff 71267

View Options

CMakeLists.txt

Loading...
View Options

src/CMakeLists.txt

Loading...