This cleans up some of the code, moves and deletes superfluous functions,
improves in-code docs and runtime warnings.
Details
Details
- Reviewers
- None
- Group Reviewers
KWin - Commits
- R108:cec4e57b5251: [platforms/drm] Do plane and object chore
On vt.
EDIT: And on full session from SDDM (on vt some issues were hidden interestingly).
Diff Detail
Diff Detail
- Repository
- R108 KWin
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
plugins/platforms/drm/drm_object_plane.h | ||
---|---|---|
55 | Note: this got switched so it matches how the kernel defines the enum. That's just cosmetics. It does not make a difference logic-wise since we map the enum at runtime anyway. |
plugins/platforms/drm/drm_object_plane.cpp | ||
---|---|---|
173 | This 1 is a problem. |
Comment Actions
For better accountability in case something breaks I have excluded the changes to the Type enum and the return on initializing properties. I will commit them separately.
plugins/platforms/drm/drm_object.cpp | ||
---|---|---|
157 | Simpler way qCWarning(KWIN_DRM, "%1 has unrecogrnized enum '%2'", m_propName, en->name); I didn't test whether my code compiles though... |
plugins/platforms/drm/drm_object.cpp | ||
---|---|---|
157 | True, if you want you can push it. Thanks. |