Differential D25859

Add Battery1 interface
ClosedPublic
Actions

Authored by broulik on Dec 10 2019, 5:24 PM.

Tags

Subscribers

kde-frameworks-devel

Details

Reviewers

Group Reviewers

Commits

R269:5eabf3ac55c7: Add Battery1 interface

Summary

Allows querying for a Bluetooth device's battery status.

Test Plan

Added unit tests pass
Managed to show device battery in plasmoid

Diff Detail

Repository

Lint

Lint Skipped

Unit

Unit Tests Skipped

broulik created this revision.Dec 10 2019, 5:24 PM

Restricted Application added a project: Frameworks. · View Herald TranscriptDec 10 2019, 5:24 PM

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

broulik requested review of this revision.Dec 10 2019, 5:24 PM

broulik added a dependent revision: D25860: [plasmoid] Show device battery percentage.Dec 10 2019, 5:45 PM

Fix crash due to uninitialized q ptr

drosca accepted this revision.Dec 13 2019, 1:30 PM

drosca added inline comments.

autotests/batterytest.cpp
41	If it's not needed, then just remove it.

This revision is now accepted and ready to land.Dec 13 2019, 1:30 PM

Closed by commit R269:5eabf3ac55c7: Add Battery1 interface (authored by broulik). · Explain WhyDec 13 2019, 1:57 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			autotests/CMakeLists.txt (2 lines)
M			autotests/autotests.cpp (2 lines)
A	M		autotests/batterytest.h (56 lines)
A	M		autotests/batterytest.cpp (144 lines)
M			autotests/fakebluez/CMakeLists.txt (1 line)
A	M		autotests/fakebluez/batteryinterface.h (49 lines)
A	M		autotests/fakebluez/batteryinterface.cpp (45 lines)
M			autotests/fakebluez/deviceinterface.cpp (14 lines)
A	M		autotests/interfaces/org.bluez.Battery1.xml (7 lines)
M			src/CMakeLists.txt (2 lines)
A	M		src/battery.h (83 lines)
A	M		src/battery.cpp (80 lines)
A	M		src/battery_p.h (50 lines)
M			src/device.h (14 lines)
M			src/device.cpp (5 lines)
M			src/device_p.h (1 line)
M			src/device_p.cpp (18 lines)
M			src/imports/CMakeLists.txt (1 line)
M			src/imports/bluezqtextensionplugin.cpp (2 lines)
A	M		src/imports/declarativebattery.h (45 lines)
A	M		src/imports/declarativebattery.cpp (35 lines)
M			src/imports/declarativedevice.h (6 lines)
M			src/imports/declarativedevice.cpp (22 lines)
M			src/imports/declarativedevicesmodel.h (3 lines)
M			src/imports/declarativedevicesmodel.cpp (14 lines)
A	M		src/interfaces/org.bluez.Battery1.xml (7 lines)
M			src/types.h (2 lines)
M			src/utils.h (1 line)
M			src/utils.cpp (7 lines)

Diff 71215

autotests/CMakeLists.txt

Loading...

autotests/autotests.cpp

Loading...

autotests/batterytest.h

Loading...

autotests/batterytest.cpp

Loading...

autotests/fakebluez/CMakeLists.txt

Loading...

autotests/fakebluez/batteryinterface.h

Loading...

autotests/fakebluez/batteryinterface.cpp

Loading...

autotests/fakebluez/deviceinterface.cpp

Loading...

autotests/interfaces/org.bluez.Battery1.xml

Loading...

src/CMakeLists.txt

Loading...

src/battery.h

Loading...

src/battery.cpp

Loading...

src/battery_p.h

Loading...

src/device.h

Loading...

src/device.cpp

Loading...

src/device_p.h

Loading...

src/device_p.cpp

Loading...

src/imports/CMakeLists.txt

Loading...

src/imports/bluezqtextensionplugin.cpp

Loading...

src/imports/declarativebattery.h

Loading...

src/imports/declarativebattery.cpp

Loading...

src/imports/declarativedevice.h

Loading...

src/imports/declarativedevice.cpp

Loading...

src/imports/declarativedevicesmodel.h

Loading...

src/imports/declarativedevicesmodel.cpp

Loading...

src/interfaces/org.bluez.Battery1.xml

Loading...

src/types.h

Loading...

src/utils.h

Loading...

src/utils.cpp

Loading...