Fix RRULE generation for timezones
ClosedPublic

Authored by vkrause on Dec 10 2019, 5:11 PM.

Details

Summary

libical 3.0.6 is stricter for RRULEs than previous versions and disallows
setting both the COUNT and UNTIL property at the same time. So don't do
that anymore, one is enough.

Diff Detail

Repository
R172 KCalendar Core
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
vkrause created this revision.Dec 10 2019, 5:11 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptDec 10 2019, 5:11 PM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
vkrause requested review of this revision.Dec 10 2019, 5:11 PM
winterz added a subscriber: winterz.EditedDec 10 2019, 5:28 PM

I'm so happy to see this fix.
I was unable to duplicate the problems reported in https://bugs.kde.org/show_bug.cgi?id=412751

problem though. anyone using libical < 3.0.6 (possibly including the CI) will have problems with test failures. I don't know a non-painful way around that.
for distros/users still with libical < 3.0.6 we'll just have to tell them to upgrade.

I guess the only workable answer for everyone is "upgrade your libical to 3.0.6"

problem though. anyone using libical < 3.0.6 (possibly including the CI) will have problems with test failures. I don't know a non-painful way around that.
for distros/users still with libical < 3.0.6 we'll just have to tell them to upgrade.

Are you sure? I think we wont be generating the COUNT property on older versions anymore either with this, so tests should work there too.

winterz accepted this revision.Dec 10 2019, 5:34 PM

problem though. anyone using libical < 3.0.6 (possibly including the CI) will have problems with test failures. I don't know a non-painful way around that.
for distros/users still with libical < 3.0.6 we'll just have to tell them to upgrade.

Are you sure? I think we wont be generating the COUNT property on older versions anymore either with this, so tests should work there too.

no, I just assumed.
please commit.

This revision is now accepted and ready to land.Dec 10 2019, 5:34 PM
This revision was automatically updated to reflect the committed changes.