Restore notifier on AnimationDurationFactor that was lost during KConfig XT port
ClosedPublic

Authored by crossi on Dec 10 2019, 1:09 PM.

Details

Summary

Following D25792 and D25586 only AnimationDurationFactor notifies

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
crossi created this revision.Dec 10 2019, 1:09 PM
Restricted Application added a project: Plasma. · View Herald TranscriptDec 10 2019, 1:09 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
crossi requested review of this revision.Dec 10 2019, 1:09 PM
davidedmundson accepted this revision.Dec 10 2019, 1:40 PM

It's true that's the only user of it right now, so this is technically correct.

I don't think it's a problem for us to emit changes for the other things. KConfigWatcher allows a user to see which things got changed as fine grain filtering in the receiver, there's basically no downside.
As a general rule I'm trying to move more of Plasma to use this.

Personally I wouldn't bother changing this, as we'll only have to change it back.

This revision is now accepted and ready to land.Dec 10 2019, 1:40 PM
ervin added a comment.Dec 10 2019, 2:33 PM

It's true that's the only user of it right now, so this is technically correct.

I don't think it's a problem for us to emit changes for the other things. KConfigWatcher allows a user to see which things got changed as fine grain filtering in the receiver, there's basically no downside.

Well, that's still more traffic on the bus for potentially nothing (more processing, more processes waking up). It might be negligible here but I'd be concerned at having this for all settings all the time.

This revision was automatically updated to reflect the committed changes.