Fix minor EBN issues
ClosedPublic

Authored by yurchor on Dec 9 2019, 5:58 PM.

Details

Reviewers
aacid
Group Reviewers
KDE Games
Commits
R413:b3db63bc6d56: Fix minor EBN issues
Summary
Test Plan

Compiles, installs, played one game.

Diff Detail

Repository
R413 KsirK
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 19628
Build 19646: arc lint + arc unit
yurchor created this revision.Dec 9 2019, 5:58 PM
Restricted Application added a subscriber: kde-games-devel. · View Herald TranscriptDec 9 2019, 5:58 PM
yurchor requested review of this revision.Dec 9 2019, 5:58 PM
aacid added a subscriber: aacid.Dec 9 2019, 10:01 PM
aacid added inline comments.
ksirk/GameLogic/aiColsonPlayer.cpp
964

i would prefer if you didn't change this. Changing the random generation may break stuff and qrand is marked as deprecated in the docu nowadays so may disappear in the future

yurchor marked an inline comment as done.Dec 10 2019, 6:39 AM

Thanks.

yurchor updated this revision to Diff 71153.Dec 10 2019, 6:40 AM

Do not replace rand with qrand

aacid accepted this revision.Dec 10 2019, 7:11 PM
This revision is now accepted and ready to land.Dec 10 2019, 7:11 PM
This revision was automatically updated to reflect the committed changes.