Differential D25825

Fix minor EBN issues
ClosedPublic
Actions

Authored by yurchor on Dec 9 2019, 5:58 PM.

Tags

None

Subscribers

aacid, kde-games-devel

Details

Reviewers

Group Reviewers

Commits

R413:b3db63bc6d56: Fix minor EBN issues

Summary

http://ebn.kde.org/krazy/reports/kde-4.x/kdegames/ksirk/index.html

Test Plan

Compiles, installs, played one game.

Diff Detail

Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

yurchor created this revision.Dec 9 2019, 5:58 PM

Restricted Application added a subscriber: kde-games-devel. · View Herald TranscriptDec 9 2019, 5:58 PM

yurchor requested review of this revision.Dec 9 2019, 5:58 PM

Harbormaster completed remote builds in B19628: Diff 71135.Dec 9 2019, 5:58 PM

aacid added a subscriber: aacid.Dec 9 2019, 10:01 PM

aacid added inline comments.

ksirk/GameLogic/aiColsonPlayer.cpp
964	i would prefer if you didn't change this. Changing the random generation may break stuff and qrand is marked as deprecated in the docu nowadays so may disappear in the future

Thanks.

Do not replace rand with qrand

Harbormaster completed remote builds in B19635: Diff 71153.Dec 10 2019, 6:40 AM

aacid accepted this revision.Dec 10 2019, 7:11 PM

This revision is now accepted and ready to land.Dec 10 2019, 7:11 PM

Closed by commit R413:b3db63bc6d56: Fix minor EBN issues (authored by yurchor). · Explain WhyDec 10 2019, 7:13 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			ksirk/Dialogs/jabbergameui.h (6 lines)
M			ksirk/Dialogs/kplayersetupwidget.h (8 lines)
M			ksirk/Dialogs/newGameDialogImpl.h (2 lines)
M			ksirk/Dialogs/newGameSummaryWidget.h (2 lines)
M			ksirk/Dialogs/restartOrExitDialogImpl.h (2 lines)
M			ksirk/Dialogs/tcpconnectwidget.h (2 lines)
M			ksirk/GameLogic/KMessageParts.h (4 lines)
M			ksirk/GameLogic/aiColsonPlayer.h (2 lines)
M			ksirk/GameLogic/aiColsonPlayer.cpp (4 lines)
M			ksirk/GameLogic/aiplayer.h (4 lines)
M			ksirk/GameLogic/aiplayerio.h (2 lines)
M			ksirk/GameLogic/gameautomaton.cpp (4 lines)
M			ksirk/GameLogic/goal.h (2 lines)
M			ksirk/GameLogic/goal.cpp (4 lines)
M			ksirk/decoratedgameframe.h (2 lines)
M			ksirk/kgamewin.h (2 lines)
M			ksirk/kgamewinslots.cpp (4 lines)
M			ksirk/mainMenu.h (2 lines)
M			ksirkskineditor/ksirkSkinEditorConfigDialog.h (2 lines)
M			ksirkskineditor/ksirkcontinentdefinition.h (2 lines)
M			ksirkskineditor/ksirkcountrydefinition.h (2 lines)
M			ksirkskineditor/ksirkgoaldefinition.h (2 lines)
M			ksirkskineditor/ksirknationalitydefinition.h (2 lines)
M			ksirkskineditor/ksirkskindefinition.h (2 lines)
M			ksirkskineditor/ksirkskineditorcountriesselectiondialog.h (2 lines)
M			ksirkskineditor/ksirkskineditorpixmapitem.h (2 lines)
M			ksirkskineditor/ksirkskineditorscene.h (2 lines)
M			ksirkskineditor/ksirkskineditortextitem.h (2 lines)
M			ksirkskineditor/ksirkskineditorwidget.h (2 lines)
M			ksirkskineditor/ksirkspritesdefinition.h (2 lines)
M			ksirkskineditor/mainwindow.h (2 lines)

Diff 71224

ksirk/Dialogs/jabbergameui.h

Loading...

ksirk/Dialogs/kplayersetupwidget.h

Loading...

ksirk/Dialogs/newGameDialogImpl.h

Loading...

ksirk/Dialogs/newGameSummaryWidget.h

Loading...

ksirk/Dialogs/restartOrExitDialogImpl.h

Loading...

ksirk/Dialogs/tcpconnectwidget.h

Loading...

ksirk/GameLogic/KMessageParts.h

Loading...

ksirk/GameLogic/aiColsonPlayer.h

Loading...

ksirk/GameLogic/aiColsonPlayer.cpp

Loading...

ksirk/GameLogic/aiplayer.h

Loading...

ksirk/GameLogic/aiplayerio.h

Loading...

ksirk/GameLogic/gameautomaton.cpp

Loading...

ksirk/GameLogic/goal.h

Loading...

ksirk/GameLogic/goal.cpp

Loading...

ksirk/decoratedgameframe.h

Loading...

ksirk/kgamewin.h

Loading...

ksirk/kgamewinslots.cpp

Loading...

ksirk/mainMenu.h

Loading...

ksirkskineditor/ksirkSkinEditorConfigDialog.h

Loading...

ksirkskineditor/ksirkcontinentdefinition.h

Loading...

ksirkskineditor/ksirkcountrydefinition.h

Loading...

ksirkskineditor/ksirkgoaldefinition.h

Loading...

ksirkskineditor/ksirknationalitydefinition.h

Loading...

ksirkskineditor/ksirkskindefinition.h

Loading...

ksirkskineditor/ksirkskineditorcountriesselectiondialog.h

Loading...

ksirkskineditor/ksirkskineditorpixmapitem.h

Loading...

ksirkskineditor/ksirkskineditorscene.h

Loading...

ksirkskineditor/ksirkskineditortextitem.h

Loading...

ksirkskineditor/ksirkskineditorwidget.h

Loading...

ksirkskineditor/ksirkspritesdefinition.h

Loading...

ksirkskineditor/mainwindow.h

Loading...