Add manual test for changing colorscope in components
ClosedPublic

Authored by davidedmundson on Dec 9 2019, 4:37 PM.

Details

Summary

For quickly other bugs in PC3

Test Plan

Opened qmlscene on some files
It's only for unit tests anyway

Diff Detail

Repository
R242 Plasma Framework (Library)
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 19622
Build 19640: arc lint + arc unit
davidedmundson created this revision.Dec 9 2019, 4:37 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptDec 9 2019, 4:37 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
davidedmundson requested review of this revision.Dec 9 2019, 4:37 PM
ngraham added a subscriber: ngraham.Dec 9 2019, 4:43 PM

Nice. Does this fix or obsolete D25699?

filipf added a comment.Dec 9 2019, 7:49 PM

Thanks! It will be easier to test now.

I noticed some issues with certain tests, although most seem to have already existed:

  • busyindicator3.qml -> loads, but complains about a binding loop detected for implicitHeight
  • button3.qml -> doesn't load, says Label is not a type
  • checkbox3.qml -> doesn't load, says Label is not a type
  • combobox.qml -> doesn't load, says it cannot assign object to list property children
  • progressbar.qml -> loads but complains that root is not defined
  • progressbar3.qml -> loads but complains that barSvg is not defined
  • radiobutton.qml -> doesn't load, say it expects token , at line 9
  • radiobutton3.qml -> doesn't load, says Label is not a type

The ones in bold seem to be related to this patch, but I can fix all of this in a separate patch after this one.

tests/components/radiobutton.qml
8

Two curly braces.

filipf added a comment.Dec 9 2019, 7:50 PM

Nice. Does this fix or obsolete D25699?

No, this just for easier testing of all the components with the complementary theme.

Thanks

Updated all the things.

filipf accepted this revision.Dec 9 2019, 8:34 PM

Thanks again :)

This revision is now accepted and ready to land.Dec 9 2019, 8:34 PM
This revision was automatically updated to reflect the committed changes.