Differential D25799

Added check that icu-config exists before patching
ClosedPublic
Actions

Authored by maxrd2 on Dec 7 2019, 1:16 AM.

Details

Reviewers
vonreth
bcooksley
Group Reviewers
Craft
Commits
R877:6a7b93941a4b: Added check that icu-config exists before patching
Summary

Fixes https://phabricator.kde.org/D25687 change on windows where icu-config doesn't exist

Diff Detail

Repository
R877 Craft Blueprints for KDE
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 19568
Build 19586: arc lint + arc unit
maxrd2 requested review of this revision.Dec 7 2019, 1:16 AM
maxrd2 created this revision.
maxrd2 updated this revision to Diff 71040.EditedDec 7 2019, 1:37 AM

Removed duplicate code (postInstall method)

Is cmake used only on windows msvc builds?
If that's the case I can just remove postInstall from cmake and leave it under autotools which would be neater.
I suppose msys build will create icu-config and use autotools.

bcooksley accepted this revision.Dec 7 2019, 3:01 AM

Thanks for the quick fix - i'll land this and test it out.

This revision is now accepted and ready to land.Dec 7 2019, 3:01 AM
Closed by commit R877:6a7b93941a4b: Added check that icu-config exists before patching (authored by maxrd2, committed by bcooksley). · Explain WhyDec 7 2019, 4:14 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mlibs/icu/icu.py (24 lines)

Diff 71040

View Options

libs/icu/icu.py

Loading...