Replace Q_DECL_OVERRIDE with override
ClosedPublic
Actions

Authored by nicolasfella on Dec 6 2019, 11:38 PM.

Details

Reviewers

fabiank
aacid

Group Reviewers

KDE Games

Commits

Summary

It's the modern way of doing things

Test Plan

Played a round of klondike

Repository

R410 KPatience

Branch

over

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 19562
Build 19580: arc lint + arc unit

Restricted Application added a subscriber: kde-games-devel. · View Herald Transcript

nicolasfella requested review of this revision.Dec 6 2019, 11:38 PM

I have not looked at the whole diff, but if you exactly did replace Q_DECL_OVERRIDE with override is fine

This revision is now accepted and ready to land.Dec 7 2019, 10:07 AM

What I did was
find -name "*.h" -exec sed -i s/Q_DECL_OVERRIDE/override/ {} \;
find -name "*.cpp" -exec sed -i s/Q_DECL_OVERRIDE/override/ {} \;

			Path	Packages
M			clock.h (10 lines)
M			clock.cpp (2 lines)
M			dealer.h (14 lines)
M			dealer.cpp (2 lines)
M			fortyeight.h (16 lines)
M			fortyeight.cpp (2 lines)
M			freecell.h (14 lines)
M			freecell.cpp (2 lines)
M			gameselectionscene.h (2 lines)
M			gameselectionscene.cpp (10 lines)
M			golf.h (14 lines)
M			golf.cpp (2 lines)
M			grandf.h (14 lines)
M			grandf.cpp (2 lines)
M			gypsy.h (12 lines)
M			gypsy.cpp (2 lines)
M			idiot.h (18 lines)
M			idiot.cpp (2 lines)
M			klondike.h (28 lines)
M			klondike.cpp (2 lines)
M			libkcardgame/kabstractcarddeck_p.h (2 lines)
M			libkcardgame/kcard.h (4 lines)
M			libkcardgame/kcard_p.h (4 lines)
M			libkcardgame/kcarddeck.h (8 lines)
M			libkcardgame/kcardpile.h (6 lines)
M			libkcardgame/kcardscene.h (12 lines)
M			libkcardgame/kcardthemewidget_p.h (10 lines)
M			mainwindow.h (4 lines)
M			messagebox.h (2 lines)
M			mod3.h (14 lines)
M			mod3.cpp (2 lines)
M			numbereddealdialog.h (2 lines)
M			patpile.h (4 lines)
M			patsolve/clocksolver.h (16 lines)
M			patsolve/fortyeightsolver.h (20 lines)
M			patsolve/freecellsolver.h (18 lines)
M			patsolve/golfsolver.h (20 lines)
M			patsolve/grandfsolver.h (22 lines)
M			patsolve/gypsysolver.h (18 lines)
M			patsolve/idiotsolver.h (18 lines)
M			patsolve/klondikesolver.h (22 lines)
M			patsolve/mod3solver.h (16 lines)
M			patsolve/patsolve.h (6 lines)
M			patsolve/simonsolver.h (16 lines)
M			patsolve/spidersolver.h (22 lines)
M			patsolve/yukonsolver.h (22 lines)
M			simon.h (10 lines)
M			simon.cpp (2 lines)
M			spider.h (28 lines)
M			spider.cpp (4 lines)
M			view.h (6 lines)
M			yukon.h (8 lines)
M			yukon.cpp (2 lines)