Differential D25789

Correctly report if baloo_file is unavailable
ClosedPublic
Actions

Authored by davidedmundson on Dec 6 2019, 4:35 PM.

Details

Reviewers
bruns
Commits
R293:76b81a614f10: Correctly report if baloo_file is unavailable
Summary

Add a new state. Watch for service unregistration as well as
registration.

Diff Detail

Repository
R293 Baloo
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 20007
Build 20025: arc lint + arc unit
davidedmundson created this revision.Dec 6 2019, 4:35 PM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptDec 6 2019, 4:35 PM
Restricted Application added subscribers: Baloo, kde-frameworks-devel. · View Herald Transcript
davidedmundson requested review of this revision.Dec 6 2019, 4:35 PM
ngraham added a subscriber: ngraham.Dec 6 2019, 5:32 PM

Maybe instead of "Unavailable", it could say "Not Running"?

bruns added a subscriber: bruns.Dec 7 2019, 2:15 AM
bruns added inline comments.
src/qml/experimental/monitor.cpp
75–76

The watcher should be installed unconditionally, and first.

Checking state first and the instaling the watcher is racy.

davidedmundson updated this revision to Diff 71771.Dec 18 2019, 10:19 AM

swap order to fix potential race
change i18n

davidedmundson marked an inline comment as done.Dec 18 2019, 10:27 AM
davidedmundson added inline comments.
src/qml/experimental/monitor.cpp
75–76

Good catch. Done

This revision is now accepted and ready to land.Dec 19 2019, 12:11 AM
Closed by commit R293:76b81a614f10: Correctly report if baloo_file is unavailable (authored by davidedmundson). · Explain WhyDec 20 2019, 6:11 PM
This revision was automatically updated to reflect the committed changes.
davidedmundson marked an inline comment as done.

Revision Contents
Changeset List

Diff 71771

View Options

src/file/indexerstate.h

Loading...
View Options

src/qml/experimental/monitor.h

Loading...
View Options

src/qml/experimental/monitor.cpp

Loading...