Fix build with Qt 5.14 RC
ClosedPublic
Actions

Authored by arojas on Dec 6 2019, 2:04 PM.

Details

Reviewers

dfaure
elvisangelaccio

Group Reviewers

Dolphin

Commits

R318:faa37a6138fc: Fix build with Qt 5.14 RC

Summary

Add needed Qt includes that are no longer pulled transitively.

Test Plan

Builds with Qt 5.14 RC

Repository

R318 Dolphin

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: kfm-devel. · View Herald Transcript

arojas requested review of this revision.Dec 6 2019, 2:04 PM

In D25783#573233, @mlaurent wrote:

see https://bugs.kde.org/show_bug.cgi?id=414492 user already created patch.

I see, but a patch in a bug report is not going to fix anything if they don't submit it...

This revision is now accepted and ready to land.Dec 6 2019, 9:22 PM

Please push to release/19.12

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			src/global.h (1 line)
M			src/kitemviews/kstandarditem.h (1 line)
M			src/search/dolphinsearchbox.cpp (2 lines)
M			src/settings/dolphinsettingsdialog.cpp (1 line)
M			src/settings/general/previewssettingspage.cpp (1 line)
M			src/settings/services/servicessettingspage.cpp (1 line)
M			src/views/draganddrophelper.cpp (1 line)