[Notifications] Set total amount to processed amount if no total and no error

Authored by broulik on Dec 6 2019, 8:29 AM.


Group Reviewers

Some jobs only set a processed amount and no total. This patch ensures when the job finishes, the total amount at least matches the processed amount.
The UI handles 1 out of 0 gracefully (only shows "1 file") but only if there is 1 total file will it offer to open the file.

Test Plan

The job should probably be fixed but I've seen others (I think trash job) also not doing it properly

  • Sent a file from KDE Connect to my PC, got "Open" offered for that file

One issue it seems to bring:

  • When I delete a file it now offers to "open" that when the job is done :/

Diff Detail

R120 Plasma Workspace
Lint Skipped
Unit Tests Skipped
broulik created this revision.Dec 6 2019, 8:29 AM
Restricted Application added a project: Plasma. · View Herald TranscriptDec 6 2019, 8:29 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Dec 6 2019, 8:29 AM
broulik edited the test plan for this revision. (Show Details)Dec 6 2019, 1:30 PM
broulik abandoned this revision.Dec 19 2019, 3:04 PM

Given the trash issue and the fact that fixing KDE Connect was easy, let's abandon this: https://invent.kde.org/kde/kdeconnect-kde/merge_requests/188/diffs