Ad a readOnly property to the QtQuick2 Document type which disables the loading of editor UI controls.
ClosedPublic
Actions

Authored by denexter on Dec 6 2019, 3:29 AM.

Details

Reviewers

pvuorela
leinir

Commits

Summary

This speeds up load times when simply viewing a document.

Repository

R8 Calligra

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: Calligra-Devel-list. · View Herald Transcript

denexter requested review of this revision.Dec 6 2019, 3:29 AM

components/Document.cpp
57	Looks like this is on top of Sailfish patched Calligra, upstream doesn't have lastError. Could otherwise resolve that conflict myself, but the arc tool doesn't seem to play along well, losing the metadata by doing the commit myself.

Seems to work and big impact indeed. Approving already.

This revision is now accepted and ready to land.Dec 31 2019, 10:25 AM

denexter marked an inline comment as done.

denexter added inline comments.

components/Document.cpp
57	Updated relative to an unpatched Calligra,

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			components/Document.h (5 lines)
M			components/Document.cpp (18 lines)
M			components/impl/DocumentImpl.h (2 lines)
M			components/impl/DocumentImpl.cpp (11 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	71000			Dec 6 2019, 3:27 AM	★	★
Diff 2	72472			Dec 31 2019, 11:15 AM	★	★
Diff 3	72479	933fba4	R8:bcda431ed43839440d023d8fb9ac356107f6a1bb	Dec 31 2019, 11:51 AM	★	★