Differential D25775

Check cursor_open return value
ClosedPublic
Actions

Authored by davidedmundson on Dec 5 2019, 10:32 PM.

Details

Reviewers
apol
Commits
R293:681bd3fcd65b: Check cursor_open return value
Summary

This will only fail if something else has already gone wrong, but I was
hitting a crash in the baloo runner on the first cursor fetch.

We may as well catch it and handle it gracefully with the right error message.

Test Plan

Unit tests

Diff Detail

Repository
R293 Baloo
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 19532
Build 19550: arc lint + arc unit
davidedmundson created this revision.Dec 5 2019, 10:32 PM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptDec 5 2019, 10:32 PM
Restricted Application added subscribers: Baloo, kde-frameworks-devel. · View Herald Transcript
davidedmundson requested review of this revision.Dec 5 2019, 10:32 PM
apol accepted this revision.Dec 8 2019, 8:30 PM
apol added a subscriber: apol.

Makes sense.

This revision is now accepted and ready to land.Dec 8 2019, 8:30 PM
Closed by commit R293:681bd3fcd65b: Check cursor_open return value (authored by davidedmundson). · Explain WhyDec 18 2019, 10:03 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/engine/postingdb.cpp (19 lines)

Diff 70991

View Options

src/engine/postingdb.cpp

Loading...